Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schema] Clarify type conflict warning message #13693

Merged

Conversation

stefanprobst
Copy link
Contributor

We currently show a warning message in case of conflicting field types, even when the field type has been explicitly defined with createTypes, which is a bit confusing. This tries to give more context to the warning.

See #12272 (comment) and #13028 (comment)

@CanRau
Copy link
Contributor

CanRau commented Apr 29, 2019

I like it, think it's a bit verbose, yet way better than currently.

Should I just merge it❓I never merged here, yet the big fat green button smiles at me 😄
If so, is the squash and merge button what you guys do/recommend or what's the proper protocol?

@freiksenet freiksenet merged commit 9b2be71 into gatsbyjs:infer-fixing Apr 29, 2019
@stefanprobst stefanprobst deleted the fix-typeconflict-warning branch July 8, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants