fix(themes): Handle shared parent theme with component shadowing #12883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/gatsby/src/internal-plugins/webpack-theme-component-shadowing/index.js
Outdated
Show resolved
Hide resolved
If gatsby-theme-a and gatsby-theme-b both install and use gatsby-theme-c (as a parent theme) this would cause an error to be raised when either sibling theme shadowed a component from gatsby-theme-c when it should be ignored.
johno
force-pushed
the
handle-shared-parent-theme
branch
from
53dcbf7
to
129775e
Compare
ChristopherBiscardi
approved these changes
Mar 26, 2019
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
gatsby-theme-aandgatsby-theme-bboth install and usegatsby-theme-c(as a parent theme) this would cause an errorto be raised when either sibling theme shadowed a component
from
gatsby-theme-cwhen it should be ignored.