Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Renamed remark-responsive-image-plugin #1288

Conversation

chiedo
Copy link

@chiedo chiedo commented Jun 28, 2017

Renamed the plugin and all references found as discussed here #1286 (comment)

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jun 28, 2017

Deploy preview failed.

Built with commit 665bfe2

https://app.netlify.com/sites/gatsbyjs/deploys/5957f130a700c413b433aa4c

@chiedo
Copy link
Author

chiedo commented Jun 28, 2017

@KyleAMathews wouldn't we expect it to fail since I added references to a npm package that hasn't yet been published? gatsby-remark-build-images

Also what is that deploy preview supposed to do? I just see a 404. Could you explain how your using it in a couple of sentences?

Lastly, was that an auto-generated comment by the tool or was that you?

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 28, 2017

Deploy preview ready!

Built with commit 665bfe2

https://deploy-preview-1288--gatsbygram.netlify.com

@chiedo
Copy link
Author

chiedo commented Jun 28, 2017

Nevermind on the deploy preview question. The most recent one built and it's clear now. haha

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 28, 2017

Deploy preview ready!

Built with commit 665bfe2

https://deploy-preview-1288--using-drupal.netlify.com

@KyleAMathews KyleAMathews merged commit 665bfe2 into gatsbyjs:1.0 Jul 1, 2017
@KyleAMathews
Copy link
Contributor

I ended up going with gatsby-remark-images instead (pushed some changes onto your branch) as "build" is implied.

Thanks!

@chiedo
Copy link
Author

chiedo commented Jul 3, 2017

Awesome @KyleAMathews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants