-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: chore(*): publish es versions of browser packages #12761
Conversation
@wardpeet this is probably good to re-visit now that your microbundle PR was merged, right? Or at least I thought it was merged 🙃 |
Definitely! Modern builds PR #14289 has some babel-preset changes you might want to introduce here too. We should install microbundle@next which has the latest updates. With that all set we should be able to wrap this up. |
Is anything else needs to be done here @DSchau? |
@freiksenet I'll need to pull it down again to check if microbundle has been updated. I believe @wardpeet was making some upstream changes to enable Babel (instead of Buble) which will unblock us and we can ship this! |
8e7bd47
to
ea1788e
Compare
OK, mostly working. Few notes:
Some preliminary numbers (note: primarily these are because class and other features are still being transpiled)
|
Let's close this -- when we're closer to implementing modern bundles, this will serve as a great reference implementation of one piece that will need to be done to maximize the benefit to end users. |
Description
In preparation for modern builds, we need to also publish some of our dependencies as es. We use microbundle to do that.
Currently blocked by microbundle using buble, which isn't able to minify everything as we'd want (e.g. class is still transpiled to function). This is supposed to be merged in next week or so upstream--so we'll wait for that.
Preliminary findings are that this shaves off a few kb (non-gzipped!) compared to the CommonJS transpiled version.
Note: We'll want to publish babel-preset-gatsby in a separate PR before this change.
Related Issues