Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Use a union type for an array linked node field pointing to heterogenous types #1211

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@KyleAMathews
Copy link
Contributor Author

Hit need for this while working on the contentful source plugin as you can have an array of linked mixed types but (crucially) where the order is important. E.g. pageContent is an array of fields some fields have an image and text and others are just text. I think converting this into a union type makes the most sense.

So I think I changed my mind from #928 (comment) :-)

An array/list of mixed things just makes sense from a data modeling perspective sometimes so we need to support it.

@jquense thoughts here?

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 49052d7

https://deploy-preview-1211--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 49052d7

https://deploy-preview-1211--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 49052d7

https://deploy-preview-1211--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor Author

Gonna merge now as but feel free to comment so we can tweak things before next beta.

@KyleAMathews
Copy link
Contributor Author

@0x80 do you have anything like this with your use of Contentful?

@0x80
Copy link
Contributor

0x80 commented Jun 20, 2017

@KyleAMathews No, I don't have a use-case for that currently. All my arrays are of a single type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants