fix(*): cache tracedSVG calculations when cache is present

[oorestisime]

Fix: #11997

Similar to #9059 but for tracedSVG.

[wardpeet]

sweet, mind adding some tests to make sure your cachekeys are working

[oorestisime]

hey, thanks for the feedback! I am not sure i follow here.
Is there a test somewhere doing this? Doesn't sound good to me to export the cache key generator.
But i might be seeing this completely wrong so a few more details would be appreciated!

[wardpeet]

oh sorry, more or less I mean if we call base64 twice it is only ran once.

An even better way is to mock sharp and see it only been called once but that might be not so trivial.

it(`caches base64 result`, async () => {
      const result = await base64({
        file,
        args,
      })
      const result2 = await base64({
        file,
        args,
      })

      expect(result).toMatchSnapshot()
      // it needs to be a === equal check
       expect(result).toBe(result2)
    })

[oorestisime]

Heya,

doing so would produce the same result but without actually testing cache keys. I won't be able to pass a cache object in the arguments since there is no way to import the cache as a standalone (i think).
Only solution i see here is mocking the cache object, although it seems that doing so beats the purpose of the test

[LekoArts]

Would be cool to have this in! Any follow-up questions/additions from your side @wardpeet ?

[oorestisime]

@wardpeet kind reminder :)

[wardpeet]

@oorestisime oh my bad. It looks great, can you fix conflicts and we'll merge! 👍

[oorestisime]

Rebased :) please have a close look i hope i did a correct merge, there were a lot of changes

[wardpeet]

Patched a few things. I'll be testing this one and getting this in. Thanks for your patience and rebasing it!

[oorestisime]

Yeah sorry i did this quickly because i ll be with no pc for a week so i didn't want to get it stalled! thanks for taking over !

[wardpeet]

Let's merge @oorestisime thanks for your work and patience!

[gatsbot]

Danger run resulted in 1 fail; to find out more, see the checks page.

Generated by 🚫 dangerJS