Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-google-gtag): page view and title mismatch #12033

Conversation

JacobBlomgren
Copy link
Contributor

Fixes #11592. As was noted in the issue, the google analytics plugin had the same problem, and this PR to the analytics plugin solves the issue for the gtag plugin as well. So I only applied the same changes to the gtag plugin.

@sidharthachatterjee sidharthachatterjee changed the title fix(plugin-google-gtag): page view and title mismatch fix(gatsby-plugin-google-gtag): page view and title mismatch Feb 25, 2019
@sidharthachatterjee sidharthachatterjee merged commit b95ae69 into gatsbyjs:master Feb 25, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you, @JacobBlomgren 👍

@sidharthachatterjee
Copy link
Contributor

Published in gatsby-plugin-google-gtag@1.0.14

@JacobBlomgren JacobBlomgren deleted the fix/gtag-page-title-mismatch branch February 25, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants