Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-checker): add more filters to filter out bad packages #11093

Merged
merged 3 commits into from
Apr 26, 2019
Merged

feat(gatsby-plugin-checker): add more filters to filter out bad packages #11093

merged 3 commits into from
Apr 26, 2019

Conversation

reese
Copy link
Contributor

@reese reese commented Jan 16, 2019

Description

Updating the gatsby-plugin-checker. It now filters out packages that lack a repository, have bad repo links, incorrect name formats, or lack READMEs. It also created a README in the folder to explain functionality and future features (such as automated notifications).

Related Issues

This PR stems from issue #5211 . Note that the script still doesn't automatically create issues yet. As mentioned after PR #7062, this requires a Github API key, so the best solution would likely be to put the key in an ENV variable and then run it locally. I'll leave this for a later PR.

…lack a repository, have bad repo links, incorrect name formats, or lack READMEs.
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this one! I added a few comments.

scripts/gatsby-plugin-checker/index.js Outdated Show resolved Hide resolved
scripts/gatsby-plugin-checker/index.js Outdated Show resolved Hide resolved
scripts/gatsby-plugin-checker/index.js Outdated Show resolved Hide resolved
scripts/gatsby-plugin-checker/index.js Outdated Show resolved Hide resolved
scripts/gatsby-plugin-checker/index.js Show resolved Hide resolved
@wardpeet wardpeet changed the title Updating gatsby-plugin-checker script: Issue #5211 feat(gatsby-plugin-checker): add more filters to filter out bad packages Mar 18, 2019
@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Mar 18, 2019
@LekoArts
Copy link
Contributor

Hi @reese 👋
Do you have time to address Ward's comments? Would be awesome! Thanks 😊

@reese
Copy link
Contributor Author

reese commented Mar 25, 2019

Yes, I'll get back to these once I get a chance! Sorry for the delay, hopefully will get to it in the next few days.

@wardpeet
Copy link
Contributor

wardpeet commented Apr 2, 2019

@reese I'm so sorry to let you do all this work but I think it was all for nothing. Initially I thought we were using this on www but we're not using this package anywhere. We use gatsby-source-npm-package-search.

Maybe you're using it and have a use case you want to share?

@reese
Copy link
Contributor Author

reese commented Apr 2, 2019

@wardpeet This was a script that was requested in Issue #5211. The goal initially was to have this script available for manual usage. The idea is that since not all repos mention the gatsby-plugin keyword in their package.json, this script would be a way to collect those repos so that people could reach out to the maintainers and have them add the keyword if they wanted to appear on the Gatsby site. Eventually this would all be automated. That said, this issue might be stale by now, the original issue was closed so there may not be a need for it any more.

@wardpeet
Copy link
Contributor

wardpeet commented Apr 2, 2019

thanks @reese I was just going to circle back to you. I talked with @pieh and he said the same thing as you mentioned here in the comment so forgive me 😉. I'm testing it and let's merge this afterwards! 😄

@LekoArts LekoArts added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Apr 24, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long! This is amazing! Thanks so much for updating this script!

@wardpeet wardpeet merged commit 8d9b104 into gatsbyjs:master Apr 26, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 26, 2019

Holy buckets, @reese — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants