Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template-blog-post.js #10846

Closed
wants to merge 1 commit into from
Closed

Conversation

marvinjude
Copy link
Contributor

Fixed issue

Description

Some blog posts on gatsbyjs.org have a canonicalLink, but no publishedAt key in their frontmatter. This leads to the blog post header saying (originally published at ), instead of (originally published at example.com).
if publishedAt doesn't exist i extracted the host name from the canonicalLink and rendered a <a> tag
with the host name

Related Issues

@marvinjude marvinjude requested a review from a team as a code owner January 5, 2019 06:35
@marvinjude
Copy link
Contributor Author

marvinjude commented Jan 5, 2019

I think i need to run prettier on the code . Somebody help!

@LekoArts
Copy link
Contributor

Hi! Thanks for the PR 👍 This issue was resolved in the meantime by #10855. Therefore I'll close this PR.

We absolutely want to have you as a contributor, so please take a look at our open issues for ideas, and please reach out to us on Twitter at @gatsbyjs with questions.

We offer pair programming sessions if you’d like to work with one of our maintainers to make your first contribution.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants