Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-contentful): use safe stringification for Rich Text fields #10228

Conversation

cjpete
Copy link
Contributor

@cjpete cjpete commented Nov 30, 2018

The "Beta" Rich Text field for contentful breaks when trying to load data into GraphQL that has circular references.

Using a safe stringify method prevents it falling over and instead just prevents the referenced circular data from being available.

…ular references in structured Rich Text field.
@pieh pieh changed the title [gatsby-source-contentful] Use safe stringification for Rich Text fields fix(gatsby-source-contentful): use safe stringification for Rich Text fields Dec 3, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cjpete!

@pieh pieh merged commit 2d2ac7c into gatsbyjs:master Dec 3, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 3, 2018

Holy buckets, @cjpete — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
… fields (gatsbyjs#10228)

The "Beta" Rich Text field for contentful was breaking when trying to load data into GraphQL that has circular references.

Using a safe stringify method prevents it falling over and instead just prevents the referenced circular data from being available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants