Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test report tasks to Azure pipelines #10128

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

vagisha-nidhi
Copy link
Contributor

What kind of change does this PR introduce?

This PR is related to the issue #10103
The PR helps to publish test results for reporting in Azure Pipelines.

Summary

Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR.
An example report is shown in the image below.
image
A screenshot for code coverage :
image

Does this PR introduce a breaking change?
No

@vagisha-nidhi
Copy link
Contributor Author

Here is the test report you get for the build that ran on this PR.
https://dev.azure.com/gatsbyjs/gatsby/_build/results?buildId=2533&view=ms.vss-test-web.test-result-details

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vagisha-nidhi!

@pieh pieh merged commit 7325fd9 into gatsbyjs:master Nov 26, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 26, 2018

Holy buckets, @vagisha-nidhi — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

DSchau added a commit to DSchau/gatsby that referenced this pull request Nov 26, 2018
In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22
DSchau pushed a commit that referenced this pull request Nov 27, 2018
* test: do not report coverage unless in CI

In #10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22

* add GENERATE_JEST_REPORT env var and use it with azure pipelines

* use var to hold normalized (boolean) val from env var
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

**What kind of change does this PR introduce?**
<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->
This PR is related to the issue gatsbyjs#10103 
The PR helps to publish test results for reporting in Azure Pipelines.

**Summary**
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->
Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR.
An example report is shown in the image below.
![image](https://user-images.githubusercontent.com/13175100/48767951-e8a73580-ecdd-11e8-8e6a-20d7767d7c1b.png)
A screenshot for code coverage : 
![image](https://user-images.githubusercontent.com/13175100/48795657-938e1280-ed23-11e8-88d0-bf94f610d774.png)


**Does this PR introduce a breaking change?**
No
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* test: do not report coverage unless in CI

In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22

* add GENERATE_JEST_REPORT env var and use it with azure pipelines

* use var to hold normalized (boolean) val from env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants