fix(gatsby-remark-images-contentful): add in missing colon for the fallback src #10041
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
approved these changes
Nov 20, 2018
|
Holy buckets, @BayPhillips — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Successfully published:
|
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…llback src (gatsbyjs#10041) Hey there. I was looking to add in AMP support for my pages, and noticed my Contentful images weren't able to be fetched properly because the URLs were invalid: ``` https//images.ctfassets.net/sk06mmp11skx/6FZZJDW2VGcEMM2sCyKI6w/32a06680dc5ba66c69925befe2ca6ace/costs-estimate.JPG ``` I noticed it was missing a `:`, as were the plugin's tests!. This resolves that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there. I was looking to add in AMP support for my pages, and noticed my Contentful images weren't able to be fetched properly because the URLs were invalid:
I noticed it was missing a
:, as were the plugin's tests!. This resolves that.