-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React 0.14 and React Router 1.0 #32
Comments
Upgrade guide here. |
am interested in working on this one. @KyleAMathews, looks like, for react-router, the files to edit are static-entry and web-entry. Is that right? Also, do you want to wait until actual releases? or have an implementation that uses the rc1 of each? |
That'd be great! Yeah those two + Thanks! Looking forward to your PR. Oh and on timing, let's wait to do an actual release when both of their On Thu, Sep 17, 2015 at 10:23 AM Phlogistic Fugu notifications@github.com
|
API shouldn't change while they move out from -rc, should they? |
Re: ES6 conversion Re: releases and rc1 |
The API shouldn't change no. I'm more concerned about potential bugs. But also as far as Gatsby is concerned, users of gatsby are pretty insulated from both router and react so upgrading is more of a keeping up with times than any major improvements. Well other than code splitting on routes. That'll be very nice as people start to build bigger sites on gatsby. |
There's an issue already btw for code splitting #10 Also @phlogisticfugu converting to ES6 is the plan so not at all boat rocking :) @gesposito has actually been converting the starter sites + wrapper components recently. |
Hey @KyleAMathews I can work on react router upgrade. Should I just send a PR? |
Thanks @knowbody! |
Yep sorry I didn't end up submitting a PR, things have gotten hectic so I haven't gotten to playing with this. glad to see you jumping in @knowbody ! |
#111 |
@knowbody how close is RR 2.0 to landing? |
0.8 has React-Router 2.0 now 🎉 |
If someone wants to grab this, this would be an easy first PR.
The text was updated successfully, but these errors were encountered: