Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-node try catch hides errors in modifyWebpackConfig #227

Closed
BerkeleyTrue opened this issue Mar 31, 2016 · 3 comments
Closed

gatsby-node try catch hides errors in modifyWebpackConfig #227

BerkeleyTrue opened this issue Mar 31, 2016 · 3 comments

Comments

@BerkeleyTrue
Copy link

If an require fails in this try/catch lib/utils/webpack.config.js for a reason other than the file is non-existent, the try/catch will swallow the error without information the user of the error.

@BerkeleyTrue BerkeleyTrue changed the title gatsby-node try catch hides errors in modifyWebpacConfig gatsby-node try catch hides errors in modifyWebpackConfig Mar 31, 2016
@KyleAMathews
Copy link
Contributor

Oh good catch. Could you create a PR to fix it?
On Wed, Mar 30, 2016 at 11:14 PM Berkeley Martinez notifications@github.com
wrote:

If an require fails in this try/catch lib/utils/webpack.config.js
https://github.com/gatsbyjs/gatsby/blob/master/lib/utils/webpack.config.js#L8
for a reason other than the file is non-existent, the try/catch will
swallow the error without information the user of the error.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#227

@KyleAMathews
Copy link
Contributor

@BerkeleyTrue tell me if my fix looks right.

@BerkeleyTrue
Copy link
Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants