fix(gatsby): createNode return promise (#34399)

* always return a promise from createNode * protect against versions of gatsby that might not return a promise from createNode
gatsbyjs · Jan 4, 2022 · 8a9b023 · 8a9b023
1 parent 6ffe0af
commit 8a9b023
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/gatsby-source-contentful/src/normalize.js b/packages/gatsby-source-contentful/src/normalize.js
@@ -763,7 +763,12 @@ export const createAssetNodes = ({
     // The content of an entry is guaranteed to be updated if and only if the .sys.updatedAt field changed
     assetNode.internal.contentDigest = assetItem.sys.updatedAt
 
-    createNodePromises.push(createNode(assetNode).then(() => assetNode))
+    // if the node hasn't changed, createNode may return `undefined` instead of a Promise on some versions of Gatsby
+    const maybePromise = createNode(assetNode)
+
+    createNodePromises.push(
+      maybePromise?.then ? maybePromise.then(() => assetNode) : assetNode
+    )
   })
 
   return createNodePromises

diff --git a/packages/gatsby/src/redux/actions/public.js b/packages/gatsby/src/redux/actions/public.js
@@ -864,7 +864,7 @@ actions.createNode =
     ).find(action => action.type === `CREATE_NODE`)
 
     if (!createNodeAction) {
-      return undefined
+      return Promise.resolve(undefined)
     }
 
     const { payload: node, traceId, parentSpan } = createNodeAction