fix(gatsby-plugin-google-analytics): remove required on trackingId (#…

…27398)
gatsbyjs · Oct 12, 2020 · 3518d10 · 3518d10
1 parent 8c79fbe
commit 3518d10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/packages/gatsby-plugin-google-analytics/src/gatsby-node.js b/packages/gatsby-plugin-google-analytics/src/gatsby-node.js
@@ -1,10 +1,9 @@
 exports.pluginOptionsSchema = ({ Joi }) =>
+  // TODO: make sure that trackingId gets required() when releasing a major version
   Joi.object({
-    trackingId: Joi.string()
-      .required()
-      .description(
-        `The property ID; the tracking code won't be generated without it`
-      ),
+    trackingId: Joi.string().description(
+      `The property ID; the tracking code won't be generated without it`
+    ),
     head: Joi.boolean()
       .default(false)
       .description(

diff --git a/packages/gatsby/src/bootstrap/load-plugins/__tests__/load-plugins.ts b/packages/gatsby/src/bootstrap/load-plugins/__tests__/load-plugins.ts
@@ -268,17 +268,6 @@ describe(`Load plugins`, () => {
             "context": Object {
               "pluginName": "gatsby-plugin-google-analytics",
               "validationErrors": Array [
-                Object {
-                  "context": Object {
-                    "key": "trackingId",
-                    "label": "trackingId",
-                  },
-                  "message": "\\"trackingId\\" is required",
-                  "path": Array [
-                    "trackingId",
-                  ],
-                  "type": "any.required",
-                },
                 Object {
                   "context": Object {
                     "key": "anonymize",