Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial/part-six #24

Merged
merged 4 commits into from
Jan 12, 2020
Merged

Conversation

NileshPatel17
Copy link
Contributor

No description provided.

@NileshPatel17
Copy link
Contributor Author

This PR is ready to be review.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 I have been bit busy. I will get to it ASAP

@NileshPatel17
Copy link
Contributor Author

OK. No Problem.

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.

Reviewed till line 36
Also, we should translate line 2 and 7 also

docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
@NileshPatel17
Copy link
Contributor Author

Done. along with line 2 and 7.

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Added review for rest of the file. It will be good to go post these fixes

docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-six/index.md Outdated Show resolved Hide resolved
@NileshPatel17
Copy link
Contributor Author

Done

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯
Thank you for working on all the fixes.
Let's get this merged

@arshadkazmi42 arshadkazmi42 merged commit 90155a1 into gatsbyjs:master Jan 12, 2020
@NileshPatel17 NileshPatel17 deleted the tutorial/part-six branch January 12, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants