Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial-part eight translation #21

Merged
merged 13 commits into from
Jan 14, 2020
Merged

Tutorial-part eight translation #21

merged 13 commits into from
Jan 14, 2020

Conversation

monizb
Copy link
Contributor

@monizb monizb commented Dec 19, 2019

Hindi translation of the part eight of the Tutorial :)

@sakshamtaneja21
@SatyaRF
@arshadkazmi42

@gatsbybot gatsbybot mentioned this pull request Dec 19, 2019
Open
62 tasks
@arshadkazmi42
Copy link
Contributor

@monizb I have started with reviwing #22
I will review this, once that is merged

arshadkazmi42
arshadkazmi42 suggested changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
Added some reviews till line 23.
Let's get those closed, I will continue review post those fixes

For common translations, you can check this file
https://github.com/gatsbyjs/gatsby-hi/blob/eecbf80eb5f8a82655f443a247cf3c6b52790216/style-guide.md

docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
@monizb
Copy link
Contributor Author

monizb commented Dec 21, 2019

@arshadkazmi42 thank you, i have made the changes.

arshadkazmi42
arshadkazmi42 suggested changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good going. Added couple of more comments till 63

docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
@monizb
Copy link
Contributor Author

monizb commented Dec 25, 2019

@arshadkazmi42 Changes have been made.

@arshadkazmi42
Copy link
Contributor

@monizb There is one small issue with one of the fix. let's get that fixed and we will continue further

@monizb
Copy link
Contributor Author

monizb commented Dec 27, 2019

Done :)

arshadkazmi42
arshadkazmi42 suggested changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review till 119

docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
@monizb
Copy link
Contributor Author

monizb commented Jan 5, 2020

Done.

arshadkazmi42
arshadkazmi42 suggested changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more reviews till 332

docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
@monizb
Copy link
Contributor Author

monizb commented Jan 8, 2020

Done.

@arshadkazmi42
Copy link
Contributor

@monizb You did some typo in two of the queries. Let's get those closed. Then I will start with further review.

@monizb
Copy link
Contributor Author

monizb commented Jan 10, 2020

Done 👍

arshadkazmi42
arshadkazmi42 suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Done with the review of rest of the files.
Once these are fixed, this will be good to to go from my end

docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-eight/index.md Outdated Show resolved Hide resolved
@monizb
Copy link
Contributor Author

monizb commented Jan 12, 2020

Done

@arshadkazmi42
Copy link
Contributor

@monizb Added a couple of feedbacks, lets get those fixed and post that we will merge this

@monizb
Copy link
Contributor Author

monizb commented Jan 13, 2020

Sorry for the typos, hope that fixes everything.

@arshadkazmi42
Copy link
Contributor

@monizb You missed two more again

@monizb
Copy link
Contributor Author

monizb commented Jan 14, 2020

Done.

arshadkazmi42
arshadkazmi42 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉
Thank you for working on all the feedbacks
Let's get this merged.

@arshadkazmi42 arshadkazmi42 merged commit 69a6ef3 into master Jan 14, 2020
@monizb monizb deleted the monizb-part-eight-tutorial-hindi branch January 14, 2020 17:57
@monizb monizb restored the monizb-part-eight-tutorial-hindi branch January 14, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaekhjamal shaekhjamal shaekhjamal left review comments

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

@sakshamtaneja21 sakshamtaneja21 Awaiting requested review from sakshamtaneja21

@SatyaRF SatyaRF Awaiting requested review from SatyaRF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monizb @arshadkazmi42 @shaekhjamal