-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial-part eight translation #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start.
Added some reviews till line 23.
Let's get those closed, I will continue review post those fixes
For common translations, you can check this file
https://github.com/gatsbyjs/gatsby-hi/blob/eecbf80eb5f8a82655f443a247cf3c6b52790216/style-guide.md
@arshadkazmi42 thank you, i have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good going. Added couple of more comments till 63
@arshadkazmi42 Changes have been made. |
@monizb There is one small issue with one of the fix. let's get that fixed and we will continue further |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review till 119
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more reviews till 332
Done. |
@monizb You did some typo in two of the queries. Let's get those closed. Then I will start with further review. |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Done with the review of rest of the files.
Once these are fixed, this will be good to to go from my end
Done |
@monizb Added a couple of feedbacks, lets get those fixed and post that we will merge this |
Sorry for the typos, hope that fixes everything. |
@monizb You missed two more again |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🎉
Thank you for working on all the feedbacks
Let's get this merged.
Hindi translation of the part eight of the Tutorial :)
@sakshamtaneja21
@SatyaRF
@arshadkazmi42