Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate part-three to Hindi #17

Merged
merged 8 commits into from
Nov 30, 2019
Merged

translate part-three to Hindi #17

merged 8 commits into from
Nov 30, 2019

Conversation

KiranAkadas
Copy link
Contributor

Addresses #1

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 👍

Review has been done till line 19.
Let us get these fixed and then we will continue further

docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Done

@arshadkazmi42
Copy link
Contributor

Done

Great work with the fixes. I have added two more suggestions, can you get those fixed and we will continue with the review post that

@KiranAkadas
Copy link
Contributor Author

Done

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Added review till 41

docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Done

@arshadkazmi42
Copy link
Contributor

@KiranAkadas Added few more suggestions

@KiranAkadas
Copy link
Contributor Author

Fixed them!

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with fixes till now.
I have reviewed rest of the file.
Lets get these fixed and it will be good to go from my end

docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-three/index.md Outdated Show resolved Hide resolved
@KiranAkadas
Copy link
Contributor Author

Made all the changes :)

@arshadkazmi42
Copy link
Contributor

Nice work. A couple of fixes more and this will be good to go

@KiranAkadas
Copy link
Contributor Author

Done :)

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉
Looks good. Let's get this merged 👍

@arshadkazmi42 arshadkazmi42 merged commit eca1dd2 into gatsbyjs:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants