-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/gatsby-cli.md translation #11
docs/gatsby-cli.md translation #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start.
I have added couple of feedbacks till line 41.
You can work on fixing those. Once those are fixed I will continue with the review for rest of the file
ee49258
to
fd61805
Compare
fd61805
to
8dd4f26
Compare
changes done. |
@NileshPatel17 Added some comments, you have missed a couple of changes. |
bc78c34
to
5e68fbb
Compare
fixed all changes, and also reviewed entire document again. |
@NileshPatel17 Thank you for working on the feedbacks. |
5e68fbb
to
8e69d0b
Compare
new code pushed. |
post new code pushed, when i go to review comment section, i do not see new changes in some cases. |
feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url |
so, you switch between conversation and file changed tab while reviewing the issues? |
correct |
are you good to resume the review process or are you waiting from my end. Please let me know. |
@NileshPatel17 I will review it later today. Thanks for waiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with fixes.
Added review till 115.
Let's get these feedback closed then we will contrinue with rest of the file review
except 2-3 items, rest done. |
@NileshPatel17 Good work 👍 . Added few comments on couple of feedbacks. Can you work on those? We will resume review post these fixes |
Done. |
Added comments, let me know if you need anything else. Can you work on the unresolved feedbacks. |
Great. only 1 is pending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work till now. Thank you for working on the fixes.
I have reviewed the whole file and added few more review feedbacks.
Once these are fixed, this PR will be ready to merge
Looks good to me. let me know if i miss out any thing or any mistake |
@NileshPatel17 Great job. Added some more feedbacks. |
overall looks good to me now. |
@NileshPatel17 Great work. Just 1 more to fix, and we will get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job ❤️
Thank you for working on all the feedbacks and suggestions.
Lets get this merged 👍
Holy buckets, @NileshPatel17 — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Thanks and congrats on landing your first PR. |
@arshadkazmi42 Thanks! |
No description provided.