Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/gatsby-cli.md translation #11

Merged
merged 15 commits into from
Nov 14, 2019

Conversation

NileshPatel17
Copy link
Contributor

No description provided.

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
I have added couple of feedbacks till line 41.
You can work on fixing those. Once those are fixed I will continue with the review for rest of the file

docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
@NileshPatel17
Copy link
Contributor Author

changes done.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 Added some comments, you have missed a couple of changes.

@NileshPatel17 NileshPatel17 force-pushed the docs/gatsby-cli branch 2 times, most recently from bc78c34 to 5e68fbb Compare November 10, 2019 12:06
@NileshPatel17
Copy link
Contributor Author

fixed all changes, and also reviewed entire document again.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 Thank you for working on the feedbacks.
There is two more feedbacks pending, once those are fixed I will review the rest of the document.

@NileshPatel17
Copy link
Contributor Author

new code pushed.

@NileshPatel17
Copy link
Contributor Author

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

@arshadkazmi42
Copy link
Contributor

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url
https://github.com/gatsbyjs/gatsby-hi/pull/11/files

@NileshPatel17
Copy link
Contributor Author

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url
https://github.com/gatsbyjs/gatsby-hi/pull/11/files

so, you switch between conversation and file changed tab while reviewing the issues?

@arshadkazmi42
Copy link
Contributor

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url
https://github.com/gatsbyjs/gatsby-hi/pull/11/files

so, you switch between conversation and file changed tab while reviewing the issues?

correct

@NileshPatel17
Copy link
Contributor Author

are you good to resume the review process or are you waiting from my end. Please let me know.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 I will review it later today. Thanks for waiting

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with fixes.
Added review till 115.
Let's get these feedback closed then we will contrinue with rest of the file review

docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
@NileshPatel17
Copy link
Contributor Author

Great work with fixes.
Added review till 115.
Let's get these feedback closed then we will contrinue with rest of the file review

except 2-3 items, rest done.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 Good work 👍 . Added few comments on couple of feedbacks. Can you work on those? We will resume review post these fixes

@NileshPatel17
Copy link
Contributor Author

@NileshPatel17 Good work . Added few comments on couple of feedbacks. Can you work on those? We will resume review post these fixes

Done.

@arshadkazmi42
Copy link
Contributor

Added comments, let me know if you need anything else. Can you work on the unresolved feedbacks.
Thanks

@arshadkazmi42
Copy link
Contributor

Great. only 1 is pending

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work till now. Thank you for working on the fixes.
I have reviewed the whole file and added few more review feedbacks.
Once these are fixed, this PR will be ready to merge

docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
docs/docs/gatsby-cli.md Outdated Show resolved Hide resolved
@NileshPatel17
Copy link
Contributor Author

Looks good to me. let me know if i miss out any thing or any mistake

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 Great job. Added some more feedbacks.
Few were missed. Let's get those closed and get this PR landed

@NileshPatel17
Copy link
Contributor Author

overall looks good to me now.

@arshadkazmi42
Copy link
Contributor

@NileshPatel17 Great work. Just 1 more to fix, and we will get this merged

Copy link
Contributor

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job ❤️
Thank you for working on all the feedbacks and suggestions.
Lets get this merged 👍

@arshadkazmi42 arshadkazmi42 merged commit 38d479d into gatsbyjs:master Nov 14, 2019
@gatsbot
Copy link

gatsbot bot commented Nov 14, 2019

Holy buckets, @NileshPatel17 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@arshadkazmi42
Copy link
Contributor

Holy buckets, @NileshPatel17 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. **We’d like to send you some Gatsby swag.** As a token of our appreciation, you can go to the [Gatsby Swag Store](https://store.gatsbyjs.org) and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock _even more_ free swag with 5 contributions — wink wink nudge nudge.) See [gatsby.dev/swag](https://gatsby.dev/swag) for details.

2. **We just invited you to join the Gatsby organization on GitHub.** This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Thanks and congrats on landing your first PR.
You can claim your welcome swag from above URL. 🎉

@NileshPatel17
Copy link
Contributor Author

@arshadkazmi42 Thanks!

@NileshPatel17 NileshPatel17 deleted the docs/gatsby-cli branch November 14, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants