Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Process #2

Closed
arshadkazmi42 opened this issue Oct 31, 2019 · 1 comment · Fixed by #5
Closed

Review Process #2

arshadkazmi42 opened this issue Oct 31, 2019 · 1 comment · Fixed by #5

Comments

@arshadkazmi42
Copy link
Contributor

arshadkazmi42 commented Oct 31, 2019 •
edited
Loading

For reviewing we follow this process.

  • Add the list of all the section names (in english) in the pull request description, which reviewer will mark check as and when the review of each section is getting completed.
  • You should not resolve review feedback, you can add a comment or an any (👍) emoji to every review comment once it's resolved and pushed.
  • A reviewer will review the changes and resolve the conversations

Note: Minimum one reviewers approval needed to get the PR merged
@arshadkazmi42 arshadkazmi42 pinned this issue Oct 31, 2019
@arshadkazmi42 arshadkazmi42 mentioned this issue Oct 31, 2019
Merged
@arshadkazmi42
Copy link
Contributor Author

Created a PR for this. We will move this to contributing.md doc

@arshadkazmi42 arshadkazmi42 unpinned this issue Nov 7, 2019
tesseralis added a commit that referenced this issue Feb 12, 2020
@tesseralis
Merge pull request #2 from MichaelDeBoey/prettier
6b401cf 
Add Prettier config + pre-commit hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add contributing.md file gatsbyjs/gatsby-hi
1 participant
@arshadkazmi42