Release v0.2.0 #211
Release v0.2.0 #211
Conversation
| @@ -14,9 +14,6 @@ namePrefix: gatekeeper-operator- | |||
| commonLabels: | |||
There was a problem hiding this comment.
Do we need to commit these changes?
There was a problem hiding this comment.
I can investigate the changes but I'd like to see make release and make bundle idempotent.
There was a problem hiding this comment.
💯 agree. In the past I've had issues trying to maintain what the correct idempotent state of the file should be, as certain commands would alter it again and then break CI because it detected a change that was not committed. This may have been fixed now as clearly the tests have passed.
There was a problem hiding this comment.
Can you run make release and see if the results match? It's kustomize
$ kustomize version
{Version:unknown GitCommit:$Format:%H$ BuildDate:1970-01-01T00:00:00Z GoOs:linux GoArch:amd64}
| @@ -45,31 +42,8 @@ patchesStrategicMerge: | |||
| #- webhookcainjection_patch.yaml | |||
|
|
|||
| # the following config is for teaching kustomize how to do var substitution | |||
| vars: | |||
There was a problem hiding this comment.
This is scaffolding from operator-sdk. Not sure we should remove. Thoughts?
| # All RBAC will be applied under this service account in | ||
| # the deployment namespace. You may comment out this resource | ||
| # if your manager will use a service account that exists at | ||
| # runtime. Be sure to update RoleBinding and ClusterRoleBinding | ||
| # subjects if changing service account names. | ||
| # Comment the following 4 lines if you want to disable |
There was a problem hiding this comment.
Do we need to commit these changes?
No description provided.