Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safety precautions for on_idle hook #864

Merged

safety precautions for on_idle hook

011e11e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

safety precautions for on_idle hook #864

safety precautions for on_idle hook
011e11e
Select commit
Loading
Failed to load commit list.
GitHub Actions / E2E report yarn test-parallel-autocompound failed Dec 9, 2024 in 1s

E2E report yarn test-parallel-autocompound ❌

Tests failed

❌ e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

23 tests were completed in 703s with 11 passed, 12 failed and 0 skipped.

Test suite Passed Failed Skipped Time
test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts 1✅ 4❌ 329s
test/parallel/xyk-pallet.API.parachainStacking.activateRewards.test.ts 1✅ 60s
test/parallel/xyk-pallet.API.pool.deactivatedLiq.test.ts 1✅ 137s
test/parallel/xyk-pallet.API.pool.promoting.test.ts 1✅ 329s
test/parallel/xyk-pallet.API.pool.weightedPools.test.ts 4✅ 2❌ 701s
test/parallel/xyk-pallet.API.poolLiqidity.claimReward.test.ts 2✅ 1❌ 461s
test/parallel/xyk-pallet.API.poolLiqidity.mintLiqudity.test.ts 1✅ 2❌ 101s
test/parallel/xyk-pallet.API.validateStatus.test.ts 3❌ 167s

❌ test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts

Accuracy > Shared pool
  ❌ Each user who minted owns the same % of tokens - one user gets extra token
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
  ❌ Each user who minted onws the same % of tokens - two users gets the extra
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
  ❌ Each user who minted onws the same % of tokens - divisible by 3
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
  ❌ Each user who minted different % of tokens [50k,25k,5k]- get diff amounts
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
✅ Given 3 users that minted liquidity WHEN only one activated the rewards THEN all rewards belongs to him on this pool

✅ test/parallel/xyk-pallet.API.parachainStacking.activateRewards.test.ts

✅ Given a user with bonded but not activated liq tokens WHEN he tries to activate THEN the tokens are activated for rewards

✅ test/parallel/xyk-pallet.API.pool.deactivatedLiq.test.ts

✅ GIVEN a disabled pool the user can still interact with it: Burn, deactivate Liq

✅ test/parallel/xyk-pallet.API.pool.promoting.test.ts

✅ GIVEN a promoted pool WHEN more pools gets activated THEN shares are decreased and equally divided among all the activated pools

❌ test/parallel/xyk-pallet.API.pool.weightedPools.test.ts

✅ Check that we can get the list of promoted pools with proofOfStake.promotedPoolRewards data storage
✅ Validate that weight can be modified by using updatePoolPromotion AND only sudo can update weights
✅ Testing that the sum of the weights can be greater than 100
❌ GIVEN a pool WHEN it has configured with 0 THEN no new issuance will be reserved
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
❌ GIVEN a deactivated pool WHEN its configured with more weight, THEN rewards are now active, new users can get portion of those rewards AND issuance grows
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
✅ GIVEN an activated pool WHEN pool was deactivated THEN check that the user will still get some rewards from the curve, and storage is updated

❌ test/parallel/xyk-pallet.API.poolLiqidity.claimReward.test.ts

❌ Check that rewards are generated and can be claimed on each session, then burn all tokens and rewards wont be available
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
✅ Given a pool with 2 users with activated rewards WHEN more than one period last AND the user burn all liquidity THEN pool is destroyed but users can still claim pending rewards
✅ Given a pool with user with activated rewards  WHEN it was deactivated AND activated again THEN the user can receive a reward in both a deactivated and activated pool

❌ test/parallel/xyk-pallet.API.poolLiqidity.mintLiqudity.test.ts

❌ Check that a user that mints on a promoted pool liquidity tokens are reserved
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
❌ Check that a user that mints on a non-promoted pool liquidity tokens are free
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
✅ Given 3 pool: token1-MGX, token2-MGX and token1-token2 WHEN token1-token2 is promoted THEN user can receive rewards from token1-token2 pool

❌ test/parallel/xyk-pallet.API.validateStatus.test.ts

Validate initial status
  ❌ User just minted on a promoted pool
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
  ❌ User just minted and rewards generated
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
  ❌ User just minted on a promoted pool and after rewards being generated mint some more
	TypeError: Cannot read properties of undefined (reading 'mintLiquidity')

Annotations

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts ► Accuracy > Shared pool ► Each user who minted owns the same % of tokens - one user gets extra token

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts ► Accuracy > Shared pool ► Each user who minted onws the same % of tokens - two users gets the extra

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts ► Accuracy > Shared pool ► Each user who minted onws the same % of tokens - divisible by 3

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.accuracy.shared.pool.test.ts ► Accuracy > Shared pool ► Each user who minted different % of tokens [50k,25k,5k]- get diff amounts

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.pool.weightedPools.test.ts ► GIVEN a pool WHEN it has configured with 0 THEN no new issuance will be reserved

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.pool.weightedPools.test.ts ► GIVEN a deactivated pool WHEN its configured with more weight, THEN rewards are now active, new users can get portion of those rewards AND issuance grows

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.poolLiqidity.claimReward.test.ts ► Check that rewards are generated and can be claimed on each session, then burn all tokens and rewards wont be available

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.poolLiqidity.mintLiqudity.test.ts ► Check that a user that mints on a promoted pool liquidity tokens are reserved

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.poolLiqidity.mintLiqudity.test.ts ► Check that a user that mints on a non-promoted pool liquidity tokens are free

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.validateStatus.test.ts ► Validate initial status ► User just minted on a promoted pool

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-parallel-autocompound

test/parallel/xyk-pallet.API.validateStatus.test.ts ► Validate initial status ► User just minted and rewards generated

Failed test found in:
  e2eTests/reports/junit.xml-78c65740-b609-11ef-a6bc-711d85a22359.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
Raw output
TypeError: Cannot read properties of undefined (reading 'mintLiquidity')
    at mintLiquidity (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:3854:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)