Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage migration asset registry #539

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

devdanco
Copy link
Member

No description provided.

@devdanco devdanco requested review from mateuszaaa and vanderian July 25, 2023 13:03
vanderian
vanderian previously approved these changes Jul 25, 2023
runtime/mangata-kusama/src/migration.rs Outdated Show resolved Hide resolved
runtime/mangata-kusama/src/migration.rs Outdated Show resolved Hide resolved
runtime/mangata-kusama/src/migration.rs Outdated Show resolved Hide resolved
runtime/mangata-kusama/src/migration.rs Outdated Show resolved Hide resolved
use sp_runtime::traits::Zero;
use xcm::IntoVersion;

pub struct AssetRegistryMigration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] ideally AssetRegistryMigration should be put in common_runtime. Then you will have no access to Runtime directly but you can make AssetRegistryMigration generic over Runtime with proper bounds

https://github.com/mangata-finance/mangata-node/blob/3a395521bf47d15d6eeb669c36df1e1c7a8d6e8a/runtime/common/src/lib.rs#L457-L468

@devdanco devdanco merged commit 8eaa196 into develop Jul 31, 2023
@devdanco devdanco deleted the feature/storage-migration-asset-registry branch July 31, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants