Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route groups #9

Open
chrispecoraro opened this issue Sep 26, 2016 · 6 comments
Open

Route groups #9

chrispecoraro opened this issue Sep 26, 2016 · 6 comments

Comments

@chrispecoraro
Copy link

I'd like to have route groups. Have you thought about that yet?
Is anybody else working on that? Maybe I can read through the code and try to make it happen.

@garygreen
Copy link
Owner

It's not really something I would like to add. The whole benefit of having a flat list of routes is that you can see your fully qualified routes and debug any problems, search easily etc. If you displayed groups and stuff you may as well just look at your routes file.

@chrispecoraro
Copy link
Author

Would you accept a PR if I find the time to do it? We'd love to have an
accordion-type view "grouping" the groups, as we have 100's of routes and
around ten groups with a various RBAC struture in place.

On Mon, Sep 26, 2016 at 11:33 AM, Gary Green notifications@github.com
wrote:

It's not really something I would like to add. The whole benefit of having
a flat list of routes is that you can see your fully qualified routes and
debug any problems, search easily etc. If you displayed groups and stuff
you may as well just look at your routes file.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASxzKMxS1lUyJ5oX5ClG6prTSLOQXiNks5qt5F0gaJpZM4KGT3N
.

Christopher Pecoraro

http://plus.google.com/u/0/+ChristopherPecoraro/
http://twitter.com/chris__pecoraro http://facebook.com/chrispecoraro
http://linkedin.com/in/chrispecoraro
USA: +1 (724) 604-0210
Italy: +39 347 324 6720

@garygreen
Copy link
Owner

I would honestly prefer to have the routes grouped by url, of some kind, rather than ::group()s. That would mean it would work for resourceful routes as well. Though I'm not sure the best way to do that, or if it would really add much value.

Is there a particular reason why you want to see the routes grouped? Even with over 500 routes I haven't found the need to see the routes grouped. It's quite nice seeing all the routes and being able to easily search within the browser, scan through for any issues with missing middlewares, or parameter problems.

@chrispecoraro
Copy link
Author

chrispecoraro commented Sep 26, 2016

Simply because we use groups and RBAC, so I would like to simply be able to view a particular "portion" of the routes. So yeah, there could be multiple ways of sorting, filtering, and searching: by namespace, group, etc...

@andrey-helldar
Copy link

This will be implemented in my fork of this package: TheDragonCode#5

@andrey-helldar
Copy link

I understand that the question in this thread is very old and, apparently, Gary is busy with the main work, so I released my version from the fork as self-contained package.
It's easier to look at a package than to talk about its changes: https://github.com/andrey-helldar/pretty-routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants