Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove namespace and key parameters from vnode signature #5

Merged
merged 1 commit into from
Dec 14, 2014

Conversation

matthieubulte
Copy link
Contributor

just a little cosmetic change to extract the namespace and the key of a vnode from the properties parameter instead of using two Maybe String.

It just makes the code look better and makes it lighter to use as most of the time these two parameters are not used.

@garyb
Copy link
Owner

garyb commented Dec 14, 2014

Much preferrable, thanks. 👍 This is the approach virtual-dom/h takes too, which if I'd know about at the time I'd probably have gone with also.

garyb added a commit that referenced this pull request Dec 14, 2014
remove namespace and key parameters from vnode signature
@garyb garyb merged commit 30c3d55 into garyb:master Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants