Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge cases corrected where all machineSets were scaling down to zero #803

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Edge cases corrected where all machineSets were scaling down to zero #803

merged 6 commits into from
Mar 29, 2023

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #802

Special notes for your reviewer:

Release note:

An edge case where all the machineSets were scaled down to zero has been dealt with.

@himanshu-kun himanshu-kun requested a review from a team as a code owner March 29, 2023 06:13
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2023
@himanshu-kun himanshu-kun mentioned this pull request Mar 29, 2023
Closed
rishabh-11
rishabh-11 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2023
@himanshu-kun himanshu-kun merged commit 64ed53e into gardener:master Mar 29, 2023
@himanshu-kun himanshu-kun deleted the fix-pr-765 branch March 29, 2023 07:42
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 29, 2023
@himanshu-kun
Copy link
Contributor Author

/needs cherry-pick

@gardener-robot gardener-robot added the needs/cherry-pick Needs to be cherry-picked to older version label Mar 29, 2023
@himanshu-kun himanshu-kun mentioned this pull request Mar 29, 2023
Merged
himanshu-kun added a commit that referenced this pull request Mar 29, 2023
@himanshu-kun @unmarshall
Automated cherry pick of #803: edge cases dealt with, unit tests added (
dad03c0 
#804)

* edge cases dealt with, unit tests added

* removed printf statements

* minor fix

* error logging corrected

* added warning log

* removed unused package import

* fixed failing unit tests

---------

Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
@himanshu-kun himanshu-kun added this to the v0.49 milestone Mar 29, 2023
@himanshu-kun himanshu-kun removed the needs/cherry-pick Needs to be cherry-picked to older version label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.

Edge Case:- Rolling Update scales all machine sets to 0
7 participants
@himanshu-kun @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @unmarshall