-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-17] Add force restoring of shoots and backup entries #5123
[GEP-17] Add force restoring of shoots and backup entries #5123
Conversation
/cc @plkokanov @timebertt |
981026f
to
60dcc03
Compare
60dcc03
to
98f397c
Compare
Rebased on latest |
/assign |
98f397c
to
8159b92
Compare
/squash |
daf85e4
to
cfb7bd9
Compare
@timebertt Thanks for your review, I answered / addressed your comments in a new commit. The one open point remaining is whether the controllers should be moved to GCM or not, let's clarify this and I will further adapt the PR if needed. |
cfb7bd9
to
0306056
Compare
0306056
to
0785394
Compare
0785394
to
8c5bccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing and clarifying my comments!
/lgtm
@@ -39,6 +39,7 @@ The following tables are a summary of the feature gates that you can set on diff | |||
| WorkerPoolKubernetesVersion | `false` | `Alpha` | `1.35` | | | |||
| CopyEtcdBackupsDuringControlPlaneMigration | `false` | `Alpha` | `1.37` | | | |||
| SecretBindingProviderValidation | `false` | `Alpha` | `1.38` | | | |||
| ForceRestore | `false` | `Alpha` | `1.38` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be 1.39
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref #5190
How to categorize this PR?
/area control-plane-migration
/kind enhancement
What this PR does / why we need it:
gardenlet
to enable the forceful restoration of shoots and backup entries to the destination seed during control plane migration if the preparation for migration in the source seed is not finished after a certain grace period and is considered unlikely to succeed ("bad case" scenario).MigrationStartTime
toShoot
andBackupEntry
to be able to track how much time has elapsed since the migration of the shoot / backup entries to this seed started.ForceRestore
to be able to enable / disable this forceful restoration. It depends on the feature gatesUseDNSRecords
andCopyEtcdBackupsDuringControlPlaneMigration
being enabled.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
spec.setttings.ownerChecks.enabled=false
). Owner checks are needed in the source, because otherwise the ownership change will not be detected, and in the destination, because otherwise the owner DNS record will not be created and the destination will not overtake the source as the owner.gardenlet
, even though there are no strong reasons to prefergardenlet
over GCM. There are a few "weak" reasons:gardenlet
in such a seed would most likely also not be able to force the restoration (which is from my perspective better).Release note:
If the `ForceRestore` feature gate is enabled, the shoot's restoration to the destination seed during control plane migration will be forced if the preparation for migration in the source seed is not finished after a certain grace period and is considered unlikely to succeed ("bad case" scenario).