-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for private image access #94
Add support for private image access #94
Conversation
@dimitar-kostadinov: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Minor suggestions inline.
/test pull-gardener-extension-registry-cache-e2e-kind |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | f681c18 | pkg/component/registrycaches/registry_caches_test.go | View secret |
- | Generic High Entropy Secret | 564cd95 | pkg/component/registrycaches/registry_caches_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
3fdf3bc
to
d1db713
Compare
d1db713
to
564cd95
Compare
4e19e97
to
8905b6d
Compare
8905b6d
to
ac5f3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d7ba09ef7d3a02f51ea002343911b6f3228d7c4d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/kind enhancement, api-change
What this PR does / why we need it:
This PR introduce support for private image access.
RegistryCache
is extended with optional fieldSecretReferenceName
that contains reference to upstream registry credentials.The credentials are provided by the user in the gardener project as a
immutable
kubernetes secret (e.g.ro-docker-secret
). The secret is defined in the Shoot spec as resource reference underresources
andsecretReferenceName
points to this reference:During Shoot creation the secret is copied in the shoot namespace in the Seed with
ref-
prefix in the name.When registry cache is deployed, a secret with the same credentials is added (e.g.
registry-docker-io-7211f728
) in the managed resource and cache registry access the credentials through env vars with data from this secret.Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
Release note: