Rework image pull check in E2E tests #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/testing
gardener-prow
bot
added
the
size/L
96 tasks
dimitar-kostadinov
added
area/ipcei
|
/assign |
ialidzhikov
reviewed
May 27, 2024
|
LGTM label has been added. Git tree hash: 4424b599e6dbf846c7ad59f1194bd6278be60b20
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind test
What this PR does / why we need it:
Rework the image pull check in E2E tests.
The image pull check now use root pod executor and runs the following commands on the Node where the registry Pod is running:
jq -j '.mounts[] | select(.destination=="/var/lib/registry") | .source' /run/containerd/io.containerd.runtime.v2.task/k8s.io/<registry-container-id>/config.jsonto get the location of '/var/lib/registry' mount on the Node.cat <mount-location>/docker/registry/v2/repositories/<image-path>/_manifests/tags/<image-tag>/current/linkto get the image index blob location.jq -j '.manifests | length' %s/docker/registry/<image-index-blob-path>/blobs/%s/datato verify it is valid image index.This will allow
distrolessto be used as the base registry image and will solve E2E flakes caused by the missingscheduler-state.jsonfile.Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note: