Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the v1alpha2 API #165

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Remove the v1alpha2 API #165

merged 1 commit into from
Mar 28, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 6, 2024 •
edited
Loading

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
The PR removes the v1alpha2 API.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:

Release note:

The `registry.extensions.gardener.cloud/v1alpha2` API version is removed. Use `registry.extensions.gardener.cloud/v1alpha3` instead.

The `registry.extensions.gardener.cloud/v1alpha2` API version is removed. Before upgrading to this version, make sure that there are no usages of the `registry.extensions.gardener.cloud/v1alpha2` API version in the landscape.

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Something that is not needed anymore and can be cleaned up labels Mar 6, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 6, 2024
@ialidzhikov ialidzhikov mentioned this pull request Mar 6, 2024
Closed
96 tasks
@ialidzhikov ialidzhikov force-pushed the cleanup/v1alpha2-api branch from 4c5d168 to c97af0b Compare March 6, 2024 10:44
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@ialidzhikov
Copy link
Member Author

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review March 27, 2024 06:48
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@ialidzhikov
Copy link
Member Author

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
dimitar-kostadinov
dimitar-kostadinov reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Mar 28, 2024

LGTM label has been added.

Git tree hash: a93b6f619a9c663137b51c5aaa4c02751d3358d1

@gardener-prow gardener-prow bot merged commit c731e0d into gardener:main Mar 28, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the cleanup/v1alpha2-api branch April 2, 2024 07:40
@JordanJordanov JordanJordanov added area/ipcei IPCEI (Important Project of Common European Interest) ipcei/registry-cache-extension Registry Cache Extension labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov left review comments

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/registry-cache-extension Registry Cache Extension kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @gardener-ci-robot @dimitar-kostadinov @JordanJordanov