Introduce v1alpha3 and make the garbage collection TTL configurable #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
cla: yes
96 tasks
|
/hold |
gardener-prow
bot
added
the
do-not-merge/hold
ialidzhikov
force-pushed
the
enh/configurable-ttl
branch
from
0f10438 to
ab3f00d
Compare
|
/hold cancel |
gardener-prow
bot
removed
the
do-not-merge/hold
ialidzhikov
force-pushed
the
enh/configurable-ttl
branch
from
ab3f00d to
b0ee794
Compare
|
LGTM label has been added. Git tree hash: 9504debe6e2bc9deb67db1f54d72c8b24c5587a1
|
|
LGTM label has been added. Git tree hash: e83ff2c2d7535722df396a42d59538dd2c7cb43f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimitar-kostadinov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
JordanJordanov
added
the
area/ipcei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR introduces v1alpha3 to make the garbage collection TTL configurable. With #138 we upgraded to v3.0.0-alpha.1 of distribution/distribution. In that version the proxy's garbage collection TTL is configurable. In prior versions it was hard-coded to
168h(7 days). Making the TTL configurable is needed to increase registry-cache's efficiency. Otherwise, every blob expires and gets deleted in 7 days, then it has to pulled again.Q: Why we need to introduce v1alpha3 to make the TTL configurable?
A: v1alpha3 replaces the current
garbageCollection.enabledfield withgarbageCollection.ttl. We were so far abusing with thestorage.delete.enabledconfig option of the Distribution project to control garbage collection. With the ttl field, the GC can be natively disabled by setting ttl=0. Having only the ttl field also keeps the API simple and in sync with what the Distribution project exposes as config options for the proxy.Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note: