-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow csi-attacher component to be configured #516
allow csi-attacher component to be configured #516
Conversation
@nschad Thank you for your contribution. |
Thank you @nschad for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
199d5d5
to
716ccfd
Compare
Should be resolved hopefully |
5571f5d
to
a9477d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits from reviewing the first two commits.
Can you check the CI failures and run make verify
locally?
a9477d6
to
8695921
Compare
@nschad You need rebase this pull request with latest master branch. Please check. |
8695921
to
a6650b8
Compare
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
Signed-off-by: Niclas Schad <niclas.schad@stackit.de>
a6650b8
to
ba6c787
Compare
The PR itself looks okay, however given #572 maybe we would need a more "generic" way to map an attacher configuration to a CSI driver and not have this as a "global" setting for all drivers. WDYT? |
I agree. I made some suggestions in my last PR. However they were all refused. I don't see how to create a generic config while checking for valid flags. Personally I don't like how this PR is implemented. |
How to categorize this PR?
/kind enhancement
/kind api-change
/area storage
/platform openstack
What this PR does / why we need it:
Enables the configuration of the
csi-attacher
component by providing 5 additional flags for providing timeout and retries in case the storage is not so fast.Example config of the
gardener-extension-provider-openstack
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: