Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add missing changes from #556 back after they got lost in #651 #868

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Re-add missing changes from #556 back after they got lost in #651 #868

merged 1 commit into from
Oct 17, 2024

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind bug
/platform gcp

What this PR does / why we need it:

Re-add missing changes from #556 back after they got lost in #651

The generic handling of the overlay handling unintentionally removed the source NAT to upstream DNS server setting. This change introduces it again.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Prevent unnecessary CNI side car containers for SNAT to upstream DNS servers

@ScheererJ
Re-add missing changes from gardener#556 back after they got lost in g…
aaa8b0d 
…ardener#651

The generic handling of the overlay handling unintentionally removed the
source NAT to upstream DNS server setting. This change introduces it
again.
@ScheererJ ScheererJ requested review from a team as code owners October 17, 2024 13:21
@gardener-robot gardener-robot added the needs/review Needs review label Oct 17, 2024
@ScheererJ
Copy link
Member Author

/cc @DockToFuture @axel7born

@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
kon-angelo
kon-angelo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 17, 2024
@kon-angelo kon-angelo merged commit 78070e7 into gardener:master Oct 17, 2024
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScheererJ @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot