Improve error msg when serviceaccount.json
is in invalid json format
#723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability ops-productivity
/kind enhancement
/platform gcp
What this PR does / why we need it:
This PR enhances the error which is returned if the gcp cloud provider secret contains a
serviceaccount.json
field which is in an invalid json format and cannot be unmarshalled.Without this, if someone tries to create a
SecretBinding
to such a secret containing an invalidserviceaccount.json
the only error that is displayed is:Now the error should be more descriptive pointing to its actual cause:
Additionally, I noticed that the
readServiceAccountSecret
function is unused, so I removed it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: