Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source- prefix from BackupEntry when performing deletion #710

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Remove source- prefix from BackupEntry when performing deletion #710

merged 1 commit into from
Mar 11, 2024

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Mar 11, 2024

How to categorize this PR?

/area control-plane-migration
/kind bug
/platform gcp

What this PR does / why we need it:
This PR removes the source- prefix of the given BackupEntry when performing entry deletion

Which issue(s) this PR fixes:
Part of gardener/gardener#8730

Special notes for your reviewer:

Release note:

`source-` prefix of `BackupEntry` name is being ignored when performing entry deletion

@Kostov6 Kostov6 requested review from a team as code owners March 11, 2024 08:34
@gardener-robot gardener-robot added needs/review Needs review area/control-plane-migration Control plane migration related kind/bug Bug platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2024
@Kostov6 Kostov6 mentioned this pull request Mar 11, 2024
Closed
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2024
kon-angelo
kon-angelo approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 11, 2024
@kon-angelo kon-angelo merged commit 46d54b2 into gardener:master Mar 11, 2024
15 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/control-plane-migration Control plane migration related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kostov6 @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot