Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Consider errors from NodesChecker for finding user related issues" #595

Merged
merged 1 commit into from
May 10, 2023
Merged

Revert "Consider errors from NodesChecker for finding user related issues" #595

merged 1 commit into from
May 10, 2023

Conversation

acumino
Copy link
Member

@acumino acumino commented May 10, 2023

This reverts commit 636f5f7.

How to categorize this PR?

/area ops-productivity
/kind enhancement
/platform gcp

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-aws#748

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove the error code check from `NodesChecker` to prevent nil pointer panic.

@acumino acumino requested review from a team as code owners May 10, 2023 08:17
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 10, 2023
@acumino
Copy link
Member Author

acumino commented May 10, 2023

/invite @MartinWeindel

@shafeeqes
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2023
MartinWeindel
MartinWeindel approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 405fcf5 into gardener:release-v1.29 May 10, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acumino @shafeeqes @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot