Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the gardener-extension-admission-gcp Service topology-aware #582

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Make the gardener-extension-admission-gcp Service topology-aware #582

merged 1 commit into from
Apr 11, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area high-availability
/area networking
/kind enhancement
/platform gcp

What this PR does / why we need it:
The following Service is adapted to be topology-aware:

  • gardener-extension-admission-gcp - the Service is consumed by virtual-garden-kube-apiserver and gardener-apiserver for the webhook communication

Which issue(s) this PR fixes:
Part of gardener/gardener#6718

Special notes for your reviewer:
N/A

Release note:

The `gardener-extension-admission-gcp` Service in the `gardener-extension-admission-gcp` chart can now be configured to be topology-aware.

@gardener-robot gardener-robot added area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 30, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 30, 2023
@ialidzhikov ialidzhikov mentioned this pull request Mar 30, 2023
Closed
46 tasks
@ialidzhikov ialidzhikov marked this pull request as ready for review April 6, 2023 15:10
@ialidzhikov ialidzhikov requested review from a team as code owners April 6, 2023 15:10
@kon-angelo kon-angelo added this to the v1.29 milestone Apr 11, 2023
kon-angelo
kon-angelo approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 11, 2023
@kon-angelo
Copy link
Contributor

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2023
@kon-angelo kon-angelo merged commit 3d00a31 into gardener:master Apr 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2023
@ialidzhikov ialidzhikov deleted the enh/topology-aware-routing-admission-gcp branch May 15, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot