Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the csi-snapshot-validation Service topology-aware #574

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Make the csi-snapshot-validation Service topology-aware #574

merged 1 commit into from
Mar 28, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 20, 2023 •
edited
Loading

How to categorize this PR?

/area high-availability
/area networking
/kind enhancement
/platform gcp

What this PR does / why we need it:
The PR adds support for topology-aware traffic routing. For more details, see gardener/gardener#7191.

The following Services are adapted to be topology-aware:

  • csi-snapshot-validation - this Service is consumed by the kube-apiserver in the same control plane for the webhook communication.

Which issue(s) this PR fixes:
Part of gardener/gardener#6718

Release note:

The `csi-snapshot-validation` Service deployed by the provider-gcp extension can now be topology-aware (depending on the Seed setting and the Shoot HA failure tolerance type). For more details, see the [Topology-aware Traffic Routing documentation](https://github.com/gardener/gardener/blob/v1.66.0/docs/usage/topology_aware_routing.md).

@ialidzhikov ialidzhikov requested review from a team as code owners March 20, 2023 12:57
@gardener-robot gardener-robot added area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2023
@ialidzhikov ialidzhikov mentioned this pull request Mar 20, 2023
Closed
46 tasks
MartinWeindel
MartinWeindel approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2023
kon-angelo
kon-angelo approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 47d3d6b into gardener:master Mar 28, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 28, 2023
@ialidzhikov ialidzhikov deleted the enh/topology-aware-routing branch March 30, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @MartinWeindel @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot