Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.26 #544

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Support for Kubernetes v1.26 #544

merged 2 commits into from
Jan 30, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jan 10, 2023 •
edited
Loading

How to categorize this PR?

/area open-source usability
/kind enhancement
/platform gcp
/exp intermediate
/topology garden seed shoot
/merge squash

What this PR does / why we need it:
This PR adds support for Kubernetes 1.26 to the extension.

Which issue(s) this PR fixes:
Part of gardener/gardener#6773

Special notes for your reviewer:

  • Depends on to be opened PR for K8s 1.26 client creation, hence, PR is in draft state.
  • I have successfully validated the functionality as follows:
    • ✅ Create new clusters with versions < 1.26
    • ✅ Create new clusters with version = 1.26
    • ✅ Upgrade old clusters from version 1.25 to version 1.26
    • ✅ Delete clusters with versions < 1.26
    • ✅ Delete clusters with version = 1.26

Release note:

The provider-gcp extension does now support shoot clusters with Kubernetes version 1.26. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.26.md) before upgrading to 1.26. 
The following images are updated:
- eu.gcr.io/gardener-project/kubernetes/cloud-provider-gcp: v1.22.15 -> v1.22.17 (for Kubernetes 1.22)
- eu.gcr.io/gardener-project/kubernetes/cloud-provider-gcp: v1.23.12 -> v1.23.15 (for Kubernetes 1.23)
- eu.gcr.io/gardener-project/kubernetes/cloud-provider-gcp: v1.24.6 -> v1.24.9 (for Kubernetes 1.24)
- eu.gcr.io/gardener-project/kubernetes/cloud-provider-gcp: v1.25.2 -> v1.25.5 (for Kubernetes 1.25)

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' platform/gcp Google cloud platform/infrastructure topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2023
@ialidzhikov ialidzhikov mentioned this pull request Jan 10, 2023
Closed
20 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2023
@ialidzhikov
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 30, 2023 •
edited
Loading

Testrun: e2e-2kn9b
Workflow: e2e-2kn9b-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 9m53s    |
| bastion-test        | bastion-test        | Succeeded | 8m46s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2023
@ialidzhikov
Copy link
Member Author

I am marking this PR ready for review with the reasons provided in gardener/gardener-extension-provider-aws#680 which are also valid for provider-gcp.

@ialidzhikov ialidzhikov marked this pull request as ready for review January 30, 2023 13:34
@ialidzhikov ialidzhikov requested review from a team as code owners January 30, 2023 13:34
kon-angelo
kon-angelo approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 30, 2023
@kon-angelo kon-angelo merged commit 93251cc into master Jan 30, 2023
@kon-angelo kon-angelo deleted the kubernetes-v1.26 branch January 30, 2023 14:03
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot