Check for existing GCP service account using TF state #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
|
/invite @kon-angelo |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
kon-angelo
reviewed
Dec 14, 2022
| "github.com/gardener/gardener-extension-provider-gcp/pkg/internal" | ||
| "github.com/gardener/gardener-extension-provider-gcp/pkg/internal/infrastructure" | ||
|
|
||
| "k8s.io/apimachinery/pkg/runtime" |
There was a problem hiding this comment.
I think this needs reformating, otherwise lgtm
MartinWeindel
force-pushed
the
tf-service-accout-check
branch
from
c6102bc to
f1f4144
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
|
/test |
|
Testrun: e2e-58x8b +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 9m39s | | bastion-test | bastion-test | Succeeded | 8m39s | +---------------------+---------------------+-----------+----------+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform gcp
What this PR does / why we need it:
The decision if a GCP service account needs to be created is changed to rely on the terraformer state.
If there is already a service account, it is kept.
For new clusters one is only created if the feature gate
DisableGardenerServiceAccountCreationis set tofalse.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: