Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix buckup bucket 404 blocking deletion #536

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix buckup bucket 404 blocking deletion #536

merged 1 commit into from
Dec 12, 2022

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/platform gcp

What this PR does / why we need it:

Refactor 404 error handling for the backup bucket. The storage.ErrBucketNotExist sentinel error does not apply to the bucket operations itself like delete but rather for operations like fetching entries or Attrs. In the other cases the googleapi errors are returned directly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix an issue with the `BackupBucket` deletion not handling NotFound errors correctly.

@kon-angelo kon-angelo requested review from a team as code owners December 9, 2022 15:44
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 9, 2022
MartinWeindel
MartinWeindel approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 9, 2022
DockToFuture
DockToFuture approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit aa14902 into gardener:master Dec 12, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 12, 2022
@kon-angelo kon-angelo deleted the fix/bbucket-404 branch December 12, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kon-angelo @MartinWeindel @DockToFuture @gardener-robot-ci-3 @gardener-robot