Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutating webhook respects shoot deletion, restore and migration #528

Merged
merged 1 commit into from
Nov 30, 2022
Merged

mutating webhook respects shoot deletion, restore and migration #528

merged 1 commit into from
Nov 30, 2022

Conversation

DockToFuture
Copy link
Member

How to categorize this PR?

/area networking
/kind bug
/platform gcp

What this PR does / why we need it:
Mutating webhook respects shoot deletion, restore and migration.Before those operations failed under certain conditions. E.g.:

task "Waiting until shoot infrastructure has been reconciled" failed: shoots.core.gardener.cloud "tmn33-zb3-hs-mgr" is forbidden: cannot change shoot spec during Restore operation that is in state Processing

Which issue(s) this PR fixes:
Fixes issue similar to gardener/gardener-extension-provider-aws#659 on gcp.

Special notes for your reviewer:

Release note:

Mutating webhook respects shoot deletion, restore and migration. Before those operations failed under certain conditions.

@DockToFuture DockToFuture requested review from a team as code owners November 30, 2022 10:06
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/bug Bug platform/gcp Google cloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 30, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2022
kon-angelo
kon-angelo approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2022
@kon-angelo kon-angelo merged commit 79000b9 into gardener:release-v1.26 Nov 30, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DockToFuture @kon-angelo @gardener-robot-ci-3 @gardener-robot