Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.26] Automated cherry pick of #524: If machine image architecture is nil consider its architecture amd64 #527

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[release-v1.26] Automated cherry pick of #524: If machine image architecture is nil consider its architecture amd64 #527

merged 1 commit into from
Nov 30, 2022

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Nov 30, 2022 •
edited
Loading

/area control-plane
/kind bug

Cherry pick of #524 on release-v1.26.

#524: If machine image architecture is nil consider its architecture amd64

Release Notes:

Enhance FindMachineImage in such a way that if the machine image doesn't have an architecture field then it is set to amd64.

@kon-angelo kon-angelo requested review from a team as code owners November 30, 2022 09:11
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 30, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2022
@kon-angelo
Copy link
Contributor Author

/reviewed ok-to-test

@kon-angelo kon-angelo added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2022
MartinWeindel
MartinWeindel approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2022
@kon-angelo kon-angelo merged commit d5ee08d into gardener:release-v1.26 Nov 30, 2022
@kon-angelo kon-angelo deleted the automated-cherry-pick-of-#524-origin-release-v1.26 branch November 30, 2022 10:28
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kon-angelo @MartinWeindel @gardener-robot-ci-1 @gardener-robot @acumino