Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable network overlay for cilium by default and add tests #522

Merged
merged 1 commit into from
Dec 14, 2022
Merged

disable network overlay for cilium by default and add tests #522

merged 1 commit into from
Dec 14, 2022

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Nov 21, 2022 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement
/platform gcp

What this PR does / why we need it:
Overlay networks for newly created cilium shoot clusters are dropped now by default. To keep the overlay network networking.providerConfig.overlay.enabled: true needs to be set explicitly in the shoot spec.
Additional tests were added to the shoot mutation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Overlay networks for newly created cilium shoot clusters are dropped now by default. To keep the overlay network `networking.providerConfig.overlay.enabled: true` needs to be set explicitly in the shoot spec.

@DockToFuture DockToFuture requested review from a team as code owners November 21, 2022 14:52
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 21, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
@DockToFuture DockToFuture force-pushed the disable/cilium-overlay branch from 6374681 to b3b3df5 Compare November 24, 2022 09:47
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 24, 2022
@DockToFuture DockToFuture marked this pull request as draft November 29, 2022 07:06
@DockToFuture DockToFuture force-pushed the disable/cilium-overlay branch from b3b3df5 to 7e605dc Compare December 2, 2022 14:05
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 2, 2022
@DockToFuture DockToFuture changed the title disable network overlay for cilium by default disable network overlay for cilium by default and add tests Dec 2, 2022
@DockToFuture DockToFuture force-pushed the disable/cilium-overlay branch from 7e605dc to 695259e Compare December 2, 2022 14:10
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 2, 2022
@DockToFuture DockToFuture marked this pull request as ready for review December 7, 2022 14:29
@DockToFuture DockToFuture force-pushed the disable/cilium-overlay branch from 695259e to 142e362 Compare December 7, 2022 14:36
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 7, 2022
@DockToFuture DockToFuture force-pushed the disable/cilium-overlay branch from 142e362 to e5eb4ce Compare December 14, 2022 07:19
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 14, 2022
@kon-angelo kon-angelo added this to the v1.27 milestone Dec 14, 2022
kon-angelo
kon-angelo approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo
Copy link
Contributor

/reviewed ok-to-test

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Dec 14, 2022
@kon-angelo kon-angelo merged commit 05a7bed into gardener:master Dec 14, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 14, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2022
@DockToFuture DockToFuture deleted the disable/cilium-overlay branch December 21, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@DockToFuture @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot