Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor gardener/gardener@v1.38 and update Golang version to 1.17 #364

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Revendor gardener/gardener@v1.38 and update Golang version to 1.17 #364

merged 2 commits into from
Dec 22, 2021

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Dec 16, 2021 •
edited
Loading

How to categorize this PR?

/area open-source
/kind enhancement
/platform gcp

What this PR does / why we need it:
Revendor gardener/gardener@v1.38 and update Golang version to 1.17.

ℹ️ The branch.cfg definition is still using Golang 1.16, hence, the verify step fails. Once this PR is approved, we can adapt the branch.cfg (also update to 1.17) and then re-trigger the CI pipeline for this PR.

Which issue(s) this PR fixes:
Part of gardener/gardener#4866

Release note:

The Golang version has been updated to `1.17.5`.

Since go1.17 both `net.ParseIP` and `net.ParseCIDR` reject leading zeros in the dot-decimal notation of IPv4 addresses. With the update to go1.17, admission-gcp now rejects Shoot objects with CIDR ranges that have such leading zeros in the dot-decimal notation. Before updating to this version of admission-gcp, make sure that there are no Shoot objects with leading zeros in the dot-decimal notation of an IPv4 address. For reference: https://nvd.nist.gov/vuln/detail/CVE-2021-29923

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 16, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2021
@rfranzke
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Dec 16, 2021 •
edited
Loading

Testrun: e2e-jzc9s
Workflow: e2e-jzc9s-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 9m7s     |
| bastion-test        | bastion-test        | Failed    | 6m34s    |
+---------------------+---------------------+-----------+----------+

@tedteng
Copy link
Contributor

tedteng commented Dec 16, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Dec 16, 2021 •
edited
Loading

Testrun: e2e-hx6mp
Workflow: e2e-hx6mp-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 8m24s    |
| bastion-test        | bastion-test        | Failed    | 6m56s    |
+---------------------+---------------------+-----------+----------+

@tedteng
Copy link
Contributor

tedteng commented Dec 17, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Dec 17, 2021 •
edited
Loading

Testrun: e2e-pzsml
Workflow: e2e-pzsml-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 9m0s     |
| bastion-test        | bastion-test        | Failed    | 7m5s     |
+---------------------+---------------------+-----------+----------+

@tedteng tedteng mentioned this pull request Dec 17, 2021
Closed
@rfranzke
Copy link
Member Author

According to @tedteng, the Bastion integration test is generally broken (not related to this PR) and should be ignored.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2021
@rfranzke
Copy link
Member Author

/ready
/invite @dkistner @kon-angelo @stoyanr

@gardener-robot gardener-robot marked this pull request as ready for review December 17, 2021 12:19
@gardener-robot gardener-robot requested review from a team as code owners December 17, 2021 12:19
@stoyanr stoyanr mentioned this pull request Dec 20, 2021
Closed
46 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 21, 2021
ialidzhikov
ialidzhikov approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/squash

@gardener-robot gardener-robot added merge/squash Should be merged via 'Squash and merge' reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 22, 2021
@rfranzke rfranzke mentioned this pull request Dec 22, 2021
Merged
dkistner
dkistner approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kon-angelo
kon-angelo approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021
@rfranzke rfranzke merged commit ec26d7f into gardener:master Dec 22, 2021
@rfranzke rfranzke deleted the revendor/gardener-v1.38 branch December 22, 2021 14:01
tedteng pushed a commit to tedteng/gardener-extension-provider-gcp that referenced this pull request Dec 23, 2021
@rfranzke @tedteng
Revendor gardener/gardener@v1.38 and update Golang version to 1.17 (
57025e4 
gardener#364)

* Revendor gardener/gardener, update Golang version

* Address PR review feedback
@rfranzke rfranzke mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

@stoyanr stoyanr Awaiting requested review from stoyanr

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension kind/test Test merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rfranzke @tedteng @dkistner @ialidzhikov @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot