Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt terraformer Pod spec to the latest image #27

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 20, 2020

What this PR does / why we need it:
Adapt terraformer Pod spec to the latest image.

Which issue(s) this PR fixes:
Ref gardener-attic/gardener-extensions#597
Part of gardener/gardener#2095

Special notes for your reviewer:
This PR requires:

Release note:

`nsxt` and `random` providers are now removed from the terraform bundle.
The Terraformer does now lookup the relevant data stored in `ConfigMap`s or `Secret`s live from the system instead of relying on mounted volumes. This is a breaking change as the volume mount approach does no longer work, please adapt your manifests [according to the examples](https://github.com/gardener/terraformer/tree/master/example). The rationale behind it is to not rely on potentially stale kubelet cache while it mounts the volume which may, in rare cases, cause state loss.
`terraformer` does no longer ignore the termination signals sent to PID 1. It does now send a termination signal to the terraform process itself and waits for its completion. This should prevent rare cases in which the `terraformer` was not storing the state of created infrastructure resources.
`g/gardener-extensions` does now require the `g/terraformer@v1.0.0`.
The Packet extension does now support shoot clusters with Kubernetes version 1.18. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md) before upgrading to 1.18.

@ialidzhikov ialidzhikov requested a review from a team as a code owner March 20, 2020 15:50
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2020
@rfranzke rfranzke added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 23, 2020
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@ialidzhikov
Copy link
Member Author

/hold cancel

@ialidzhikov ialidzhikov removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 2, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@rfranzke rfranzke merged commit 31fe706 into gardener:master Apr 3, 2020
@ialidzhikov ialidzhikov deleted the fix/handle-sigterm branch May 14, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants