Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched from DockerHub to Gardener GCR #251

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Switched from DockerHub to Gardener GCR #251

merged 1 commit into from
Mar 24, 2023

Conversation

robinschneider
Copy link
Contributor

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
This PR is needed to support IPv6 single stack and avoid DockerHub pull limits as it uses copied images from Gardener GCR instead.
Part of gardener/ci-infra#619

Release note:

Switched images from DockerHub to copies in Gardener GCR

@robinschneider robinschneider requested a review from a team as a code owner March 23, 2023 14:34
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension labels Mar 23, 2023
@gardener-robot
Copy link

@robinschneider Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 23, 2023
@gardener-robot-ci-3
Copy link
Contributor

Thank you @robinschneider for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@timebertt
Copy link
Member

/hold
until gardener/ci-infra#646 is merged

@gardener-robot
Copy link

@timebertt Command /hold is not available to you but only to a Maintainer, Member, Author.

@timebertt timebertt mentioned this pull request Mar 23, 2023
Closed
11 tasks
@timebertt timebertt added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 24, 2023
timebertt
timebertt approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
now that gardener/ci-infra#646 has been merged

@gardener-robot
Copy link

@timebertt Command /lgtm is not available to you but only to a Maintainer, Member.

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2023
@timebertt
Copy link
Member

@rfranzke can you press the merge button please? :)

@rfranzke rfranzke merged commit 88505df into gardener:master Mar 24, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robinschneider @gardener-robot @gardener-robot-ci-3 @timebertt @rfranzke @gardener-robot-ci-2