Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt high-availability configuration #237

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Adapt high-availability configuration #237

merged 2 commits into from
Nov 21, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Nov 17, 2022

How to categorize this PR?

/area high-availability
/kind enhancement
/platform equinix-metal

What this PR does / why we need it:
This PR prepares components for HA by labeling them with the corresponding high-availability-config.resources.gardener.cloud/type and defining the required PodDisruptionBudget, please see this document for more information.

Which issue(s) this PR fixes:
Part of gardener/gardener#6529

Special notes for your reviewer:
The metallb doesn't provide any leader election, so the high-availability-config.resources.gardener.cloud/type label is not added by this PR.

Release note:

Extension and control-plane components have been adjusted to the high availability configuration supported by Gardener as of release `v1.60`. See [this document](https://github.com/gardener/gardener/blob/master/docs/development/high-availability.md) for more information about HA in gardener.
This release adds HA support for Equinix-Metal's control-plane components when extension is deployed along with Gardener >= `v1.60`. Please see [this document](https://github.com/gardener/gardener/blob/master/docs/usage/shoot_high_availability.md) for more information about HA settings in shoot clusters.

@timuthy timuthy requested a review from a team as a code owner November 17, 2022 14:32
@gardener-robot gardener-robot added area/high-availability High availability related kind/enhancement Enhancement, improvement, extension platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 17, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2022
@timuthy timuthy mentioned this pull request Nov 17, 2022
Closed
56 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2022
@timuthy timuthy force-pushed the enhancement.ha-config branch from 7bcd257 to 9ad8d06 Compare November 17, 2022 15:33
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2022
@timuthy timuthy force-pushed the enhancement.ha-config branch from 9ad8d06 to 448cbf7 Compare November 21, 2022 07:56
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
@rfranzke
Copy link
Member

/rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 21, 2022
@gardener-robot
Copy link

@timuthy You need rebase this pull request with latest master branch. Please check.

@timuthy timuthy force-pushed the enhancement.ha-config branch from 448cbf7 to 34bf756 Compare November 21, 2022 13:15
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
rfranzke
rfranzke reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about https://github.com/gardener/gardener-extension-provider-equinix-metal/blob/master/charts/internal/shoot-system-components/charts/metallb/templates/metallb.yaml#L366-L424?

@timuthy
Copy link
Member Author

timuthy commented Nov 21, 2022 

Special notes for your reviewer:
The [metallb](https://github.com/gardener/gardener-extension-provider-equinix-metal/tree/master/charts/internal/shoot-system-components/charts/metallb) doesn't provide any leader election, so the high-availability-config.resources.gardener.cloud/type label is not added by this PR.

@rfranzke
Copy link
Member

Well, I should really RTFM :) thanks!

rfranzke
rfranzke approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Nov 21, 2022
@rfranzke rfranzke merged commit eb3112c into gardener:master Nov 21, 2022
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/rebase Needs git rebase needs/review Needs review labels Nov 21, 2022
@timuthy timuthy deleted the enhancement.ha-config branch November 21, 2022 13:42
@schrodit schrodit mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timuthy @rfranzke @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3