Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature gate for cluster > 1.22 #226

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

schrodit
Copy link
Collaborator

@schrodit schrodit commented Aug 9, 2022

How to categorize this PR?

/area control-plane
/kind bug
/platform equinix-metal

What this PR does / why we need it:

This PR adds support for Kubernetes clusters v1.22 by removing the deprecated feature gate VolumeSnapshotDataSource for cluster with a Kubernets version > 1.22.

Without that fix, the apiserver throws:

Error: invalid argument "VolumeSnapshotDataSource=true" for "--feature-gates" flag: unrecognized feature gate: VolumeSnapshotDataSource

Special notes for your reviewer:

Release note:

Fixed a bug that caused clusters running Kubernetes version > 1.22 to crash due to the outdated feature gate `VolumeSnapshotDataSource`.

@schrodit schrodit requested a review from a team as a code owner August 9, 2022 14:07
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) labels Aug 9, 2022
@gardener-robot
Copy link

@schrodit Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2022
@rfranzke rfranzke merged commit 8840584 into gardener:master Aug 24, 2022
@gardener-robot gardener-robot added needs/lgtm Needs approval for merging status/closed Issue is closed (either delivered or triaged) reviewed/lgtm Has approval for merging and removed needs/review Needs review reviewed/lgtm Has approval for merging needs/lgtm Needs approval for merging labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants